Allow building in free-threaded python#2286
Open
ricardoV94 wants to merge 1 commit into
Open
Conversation
ricardoV94
force-pushed
the
free_threaded
branch
4 times, most recently
from
fbb512a to
48ae917
Compare
ricardoV94
force-pushed
the
free_threaded
branch
6 times, most recently
from
e16603d to
cc3a8c0
Compare
ricardoV94
force-pushed
the
free_threaded
branch
from
cc3a8c0 to
b882b77
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Now that C-backend is not the default, there's no good reason to prevent free-threaded builds.
Our C extensions are not thread-safe, but they don't claim to be, so if imported python will just re-enable the gil with a warning.
For users, care must be taken to split the memory and shared variables of a compiled function
fn.copy(share_memory=False, swap={})before threading, but that's not really new. See pymc-devs/pymc#8355 for an exampleAlso helped by #2285